TEST: bump go version to 1.23 #42960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
use the native support instead
This reverts commit 45cbfd3.
This reverts commit 9b5e2df.
v1v
commented
Feb 28, 2025
| @@ -64,6 +64,7 @@ steps: | |||
| - label: ":ubuntu: x-pack/dockerlogbeat: Ubuntu x86_64 Unit Tests" | |||
| key: "mandatory-linux-unit-test" | |||
| command: | | |||
| source .buildkite/scripts/qemu.sh | |||
There was a problem hiding this comment.
unitTest uses the golang-crossbuild hence we need to use qemu
v1v
commented
Feb 28, 2025
| @@ -164,7 +164,9 @@ steps: | |||
|
|
|||
| - label: ":ubuntu: Metricbeat: Crosscompile" | |||
| key: "mandatory-cross-compile" | |||
| command: "make -C metricbeat crosscompile" | |||
| command: | | |||
| source .buildkite/scripts/qemu.sh | |||
There was a problem hiding this comment.
crosscompile uses the golang-crossbuild hence we need to use qemu
v1v
commented
Feb 28, 2025
Comment on lines
-44
to
+46
| beatsFPMImage = "docker.elastic.co/beats-dev/fpm" | ||
| beatsFPMImage = "docker.elastic.co/observability-ci/fpm" | ||
| // BeatsCrossBuildImage is the image used for crossbuilding Beats. | ||
| BeatsCrossBuildImage = "docker.elastic.co/beats-dev/golang-crossbuild" | ||
| BeatsCrossBuildImage = "docker.elastic.co/observability-ci/golang-crossbuild" |
There was a problem hiding this comment.
This won't be needed as soon as we merge elastic/golang-crossbuild#527
v1v
commented
Feb 28, 2025
| @@ -0,0 +1,19 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Specific script that can be used in other places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use elastic/golang-crossbuild#527 on the top of #42705
Remove the qemu dependency - use the host architecture always
Use the specific golang crossbuild image for arm64 in arm64
Use the private docker namespace to validate things work ok